no more RBScanner errorBlock #12900
no more RBScanner errorBlock #12900
Conversation
|
Failing test that maybe realted: BCBeautifulCommentsSettingsTest>>testRenderingOfMyOwnComment CI problem not related:
|
MarcusDenker
added
the
Status: Need more work
|
Hum... I cannot check out the branch anymore :/ all I got is a weird nonsensical emergency alert popup.
Maybe moving around low level code broke some Iceberg expectations. |
|
Moved back old code as No-op to ease the loading :( My assumption is that old compiled methods in fresh image are still using the killed API, but the RBScanner methods are moved/removed before such client method are updated (and recompiled). Now I can reproduce the BCBeautifulCommentsSettingsTest issue, I will investigate. |
|
Yes, I think so... code loading is not atomic sadly |
|
I think it was a syntactic error in the depreciation clause (so the method just failed). |
MarcusDenker
removed
the
Status: Need more work
PR #12892 removed the last usage of errorBlock in RBScanner.
This PR does the almost final cleanup of now unused code.
Because existing images still refer to some undead method of RBScanner (
on:errorBlock:anderrorBlock:) they are kept as empty shells.Note: for some reason, moving these two methods as extension methods in Deprecated11 also break Iceberg. Possible the "move" is not atomic so the removal of the method in AST-Core is done before it is added in Deprecated11 letting the low level code experiences MNU errors.