Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://tree.taiga.io/project/penpot/task/9337 and fixes https://tree.taiga.io/project/penpot/task/9421
In this PR:
enable-render-wasm-dpr
.RenderState
now holds theViewbox
(instead ofState
and passing it toRenderState
in each method call)Viewbox
'sx
andy
topan_x
andpan_y
(since we stored them in the negative, like panning).Rect.contains
. I'm not sure if this logic mimics exactly what @superalex did (I think I need a drawing of the check he intended)Note that a large DPR hits performance greatly (for instance
2.0
dpr for a 4K display means surfaces with 4x pixels). The avatars example file we're using gets a bit laggy when zoomed out (OTOH when we introduce more performance improvements, this will benefit as well)