✨ Removed sizing variables from radius #3184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondřej Konečný <[email protected]>
|
Thank you very much @ondrejkonec Merged manually to include you in the CHANGES.md ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove sizing variables from border radius definition
Why
Since this is not critical, I'm here to help with improvement. By this change, we are preparing for scalable system (it's part of this iniciative). I think it's better not to mix spacing and other type of design decisions.
This approach can block us creating more meaningful structure. As an example, let's say we want to to update/change our spacing system and we have this spacing variables connected to radius. Everything has to be redesigned.
Another point is, that it not add any value using this properties at the moment. I'll update this radiuses when new UI is ready so we can be more complex.
It's part of my previous commits, where I created scale for border radii.
