Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix moving comment threads #2650

Merged
merged 1 commit into from
Dec 9, 2022
Merged

🐛 Fix moving comment threads #2650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
🐛 Fix moving comment threads 
Moving comment threads was failing with assert errors because the speced type is gpt/point whereas update-comment-thread-position was passing a raw map of coordinates.

Signed-off-by: Ryan Breen <[email protected]>
  • Loading branch information
Ryan Breen committed Dec 9, 2022
commit c411ce248e2ac3bc1c5ffd48c7baaa3a8d598bda
4 changes: 2 additions & 2 deletions frontend/src/app/main/data/workspace/comments.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@
page-id (:id page)
objects (wsh/lookup-page-objects state page-id)
new-frame-id (if (nil? frame-id)
(ctst/frame-id-by-position objects {:x new-x :y new-y})
(ctst/frame-id-by-position objects (gpt/point new-x new-y))
(:frame-id thread))
thread (assoc thread
:position {:x new-x :y new-y}
:position (gpt/point new-x new-y)
:frame-id new-frame-id)

changes
Expand Down