fix: append space in splitTextIntoWord if text contain logogram #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Yunin, I'm sorry for my late response but I was quite busy in the last months. After looking at your code, it does the right thing but your English and your implementation is not good enough for adopting it unchanged. That is why I have decided to implement your algorithm myself. I hope you are not disappointed now. You did a very good job at pointing me to this problem and thanks to your efforts, I have now corrected it. Again, thank you very much. |
pemistahl
added a commit
that referenced
this pull request
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed the previous request Fix word splitting algorithm for languages supporting logograms. And i open a new request, because i find that appending space in splitTextIntoWord is most easy way to sovle this issue.