Use request scheme in server url#121
Conversation
NoelDeMartin
force-pushed
the
request-uri
branch
from
205f5f7 to
3fe635a
Compare
|
Thank you for taking the time to report this! Originally, the hard-coded
This was in part to protect unknowing users against themselves. At some point, the issue of being able to run the solid pod over It looks like a similar solution was omitted in this plugin 😞 I'll discuss this internally and see what resolution we come up with. |
|
I've moved the internal discussion into the open at https://github.com/orgs/pdsinterop/discussions/2 |
|
The consensus reached in the linked discussion is to remove the HTTP(S) check completely and let the server / environment decide. |
|
Updated this patch in 4c7b29d. |
|
Merged in #173 |
3 participants
Hey, I've been playing with this in a local Nextcloud instance and could make it work after commenting a couple of things.
I think most of the issues were related to networking, so I don't think there was anything broken in the plugin (my app's clientid wasn't reachable from the Nextcloud server, etc.).
But something I found to improve is that it's assuming that instances run with
https://, which was not true in my case. Hopefully everyone useshttps://in production though :).