Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update web_server configs #412

Merged
merged 3 commits into from
Feb 24, 2023
Merged

update web_server configs #412

merged 3 commits into from
Feb 24, 2023

Conversation

aansaarii
Copy link
Contributor

This PR applies the changes suggested by Mike Ferdman.

xusine
xusine reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@xusine xusine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doubting these settings work well in general case when multiple cores are used.
For instance, the Nginx worker process is set to 1, and in this case, it cannot utilize any multicore system.

@aansaarii aansaarii requested a review from xusine February 24, 2023 10:39
@xusine xusine merged commit 8660987 into main Feb 24, 2023
@xusine xusine deleted the update_web_serving_conf branch February 24, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xusine xusine xusine approved these changes

@UlisesLuzius UlisesLuzius Awaiting requested review from UlisesLuzius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aansaarii @xusine