Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Entrypoint of Web Search #404

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Update the Entrypoint of Web Search #404

merged 6 commits into from
Feb 16, 2023

Conversation

xusine
Copy link
Contributor

@xusine xusine commented Feb 15, 2023

This PR adds the option parser and the java file generator to give the user more control of the load. Document is also updated accordingly.

@UlisesLuzius
Copy link
Collaborator

Just to recap some of the features of this commit:

  • Fix operator AND -> OR
  • Change throughput parameter parsing: modifying the java file -> command parsing
  • Change run parameter parsing -> from overwriting lines with sed to python script and ENV variables
  • Explicit argument declaration instead of inferring from parameter order

@xusine xusine merged commit e370a0b into main Feb 16, 2023
@xusine xusine deleted the web-search-entrypoint branch February 16, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesLuzius UlisesLuzius UlisesLuzius approved these changes

@aansaarii aansaarii Awaiting requested review from aansaarii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xusine @UlisesLuzius