Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counters in web-serving client #390

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix counters in web-serving client #390

merged 1 commit into from
Jan 18, 2023

Conversation

aansaarii
Copy link
Contributor

There were wrong counter descriptions and assignments in the benchmark which are fixed in this branch.

@aansaarii
Fix counters in web-serving client
51a9f80 
There were wrong counter descriptions and assignments in the benchmark which are fixed in this branch.
@aansaarii aansaarii requested a review from xusine October 24, 2022 16:06
xusine
xusine approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@xusine xusine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix. Actually, we don't have a pretty tuning rule for this workload, as it has many operations. We never pay attention to these counters while doing the measurement.

@xusine xusine merged commit 330dc34 into main Jan 18, 2023
@xusine xusine deleted the fix_web_serving_client branch January 18, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xusine xusine xusine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aansaarii @xusine