Updating the media-streaming benchmark #359
Conversation
|
A new commit is added to this PR: "fixed port allocation of httperf" |
There was a problem hiding this comment.
Hi Ali,
Thanks for your work so far on this. I have added a bunch of comments into the individual changes, which we should fix before we merge anything. You can address them as you get time.
Also, we should change the name of this PR to something correct, because it currently contains many more changes than just setting the nginx worker count.
benchmarks/media-streaming/client/files/run/peak_hunter/launch_remote.sh
Outdated
Show resolved
Hide resolved
aansaarii
changed the title
|
The new commit adds support for TLS connections. It has basically two classes of changes. On the server side, the container installs OpenSSL and generates keys in the entrypoint. On the other hand, the client container creates a TLSv1.2 context. Moreover, now it has another parameter in the entrypoint which determines whether the benchmark uses plain text or encrypted connections. |
|
A new commit is added to update the TLS version from 1.2 to 1.3. |
aansaarii
force-pushed
the
fix_streaming_server
branch
from
c7af6c0 to
399fced
Compare
…cloudsuite into fix_streaming_server
There was a problem hiding this comment.
I have looked at as many of the changes as is possible, and approved the merging with two follow-ups (as discussed):
- It would be good to divide the documentation into a README file which describes simply how to run the benchmark, and a more detailed document (perhaps a PDF) with the architecture of the load generator, how to run an experiment, and how to set various parameters to create certain scenarios. This would give more structure to each file (i.e., the README which is visible by default just explains the architecture of the benchmark and how to run it, and then more details are available for those who are curious to tune it).
- We should attempt in future to set all editors so that they do not autoformat/change spacing of code. For example, it is not possible to review the changes to files such as
core.corvideoperf.cbecause the changelist currently is polluted with simply re-spacing files or converting spaces back and forth to tabs.
In this PR, I've added the ability to fix the number of Nginx workers after the Nginx installation. The default number of workers might not be sufficient to handle the clients' load. Using this PR, the server can set the appropriate number of workers to smaller or larger numbers based on the server's capabilities.