Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pdb generation #588

Merged
merged 6 commits into from
Mar 2, 2024
Merged

Added pdb generation #588

merged 6 commits into from
Mar 2, 2024

Conversation

Aragas
Copy link
Collaborator

@Aragas Aragas commented Mar 2, 2024

  • for Thin they are embedded
  • for Fat they are portable
    Removed snupkg generation, the .pdb files are included in the nupkg

Side fix:
Exclude the secondary System.Reflection.* packages from NuGet - we were adding new dependencies that we don't really need

Aragas added 2 commits March 2, 2024 16:19
* for Thin they are embedded
* for Fat they are portable
Copy link

github-actions bot commented Mar 2, 2024

Test Results

   104 files     104 suites   8m 52s ⏱️
   232 tests    230 ✅   2 💤 0 ❌
23 920 runs  23 568 ✅ 352 💤 0 ❌

Results for commit a14165f.

@Aragas
Copy link
Collaborator Author

Aragas commented Mar 2, 2024

PR ready for merge

@pardeike pardeike merged commit 14eebba into master Mar 2, 2024
47 checks passed
@pardeike pardeike deleted the pdb-gen branch March 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants