[link] improve datalink/telemetry report #999
Conversation
- more reported data about up/down-link - cleanup report messages - display link page in GCS even in single link mode
| // timestamp in usec when last message was send | ||
| static float last_ts = 0.; | ||
| // current timestamp | ||
| uint32_t now_ts = get_sys_time_float(); |
There was a problem hiding this comment.
This should be a float...
Or use get_sys_time_usec() which has higher resolution (get_sys_time_float() has only sys_time.resolution)...
|
Somehow ping_time is not updated/computed correctly anymore.. |
|
Seems to work fine with single link connected to LisaMX... |
|
@uaarg any chance you can confirm this still works with multiple links? |
[link] improve datalink/telemetry report - more reported data about up/down-link - cleanup report messages - display link page in GCS even in single link mode closes #442
|
IMHO it would be good to keep TELEMETRY_STATUS message in default telemetry settings, so you can see ping times as before. |
|
It was a very unpleasant hack (at least to me...) to have it in telemetry class in the first place. With this code, each message is declared and used by the class it belongs to. The message LINK_REPORT is also logged, and it contains the ping time. It is just less convenient to display because log plotter doesn't support this message class. |
|
@flixr : UAARG member here. I know this is quite late, but I'll try and test these changes with multiple links soon (thinking 1-2 months). I skimmed your code changes and they look good to me so far. Definitely nice to see improvement in this area such as the link page showing data even when redundant links are not used. |
Tested in simulation, will be on real hardware soon.
Test with redundant link would be welcome since I don't have working setup for this.