Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto1] FLAPS, HATCH, BRAKE operate from the remote in AUTO1 #878

Closed
wants to merge 1 commit into from

Conversation

dewagter
Copy link
Member

No description provided.

@flixr
Copy link
Member

flixr commented Nov 5, 2014

Hm... looks like a bit of a hack to me, not convinced we should add a module for this...
Also when are the commands set in auto2?

Would probably make more sense to improve support for choosing when to map rc input to commands.
We already have rc_commands, auto_rc_commands and ap_only_commands...

@dewagter
Copy link
Member Author

dewagter commented Nov 5, 2014

Yes, that would be better.
Sounds like and rc_auto1_commands: rc in man and auto1 and flightplan in
auto2: e.g. flaps.
I just don't understand nobody else needed this before.
On Nov 5, 2014 1:53 PM, "Felix Ruess" [email protected] wrote:

Hm... looks like a bit of a hack to me, not convinced we should add a
module for this...
Also when are the commands set in auto2?

Would probably make more sense to improve support for choosing when to map
rc input to commands.
We already have rc_commands, auto_rc_commands and ap_only_commands...


Reply to this email directly or view it on GitHub
#878 (comment).

@flixr
Copy link
Member

flixr commented Nov 5, 2014

Just because nobody complained publicly it doesn't mean that nobody needed this or didn't just hack it in...
But if you have a simple aircrafts (e.g. microjet without extra flaps and stuff), then you won't need it...

@martinmm
Copy link
Member

martinmm commented Nov 5, 2014

we used the "auto_rc_commands" section in the aircraft file if we needed to command a rudder in auto1

@flixr
Copy link
Member

flixr commented Nov 5, 2014

@martinmm that works as long as you don't want to set them from flight plan in auto2

@martinmm
Copy link
Member

martinmm commented Nov 5, 2014

ok

@flixr
Copy link
Member

flixr commented Nov 5, 2014

Closing as we should implement a proper solution as tracked/described in #930

@flixr flixr closed this Nov 5, 2014
@flixr flixr deleted the flaps_and_hatch_in_auto1 branch November 5, 2014 19:46
dewagter added a commit that referenced this pull request Dec 22, 2014
flixr added a commit to flixr/paparazzi that referenced this pull request Jan 16, 2015
* master: (175 commits)
  [tests] fix math tests
  [fixedwing] use min/max_cruise_throttle variables instead of defines
  [conf] update some telemetry files
  [ext] update luftboot
  [ext] update libopencm3
  [mavlink] add sending of origin and waypoints
  [mavlink] rename SETTINGS to SETTINGS_NAMES_SHORT
  [mavlink] send quaternion
  [mavlink] parse PARAM_SET
  [conf] add AUTOPILOT_VERSION to some default telemetry files
  [conf] add python real time plotter to control panel
  [python] messagesapp: growable value column width
  [auto1-flaps] Please remove this as soon a better solution exits. For now it is critical to fly. closing paparazzi#878
  [conf] vivify fix digital_cam_uart missing settings
  [conf] obc fix nav_airspeed names, and enable AMSL
  fourth release candidate for next stable release v5.4
  [server] close file even if file empty
  [build] improve build version stuff
  Add some more flexibility to conf and control_panel naming
  [paparazzicenter] fix GLib-CRITICAL warning when running clean/build/upload
  ...

Conflicts:
	sw/airborne/boards/ardrone/actuators_at.c
	sw/airborne/firmwares/fixedwing/main_ap.c
	sw/airborne/firmwares/rotorcraft/main.c
	sw/airborne/modules/geo_mag/geo_mag.c
	sw/airborne/modules/ins/ahrs_chimu_spi.c
	sw/airborne/modules/ins/ahrs_chimu_uart.c
	sw/airborne/subsystems/ins/ins_ardrone2.c
	sw/airborne/test/subsystems/test_ahrs.c
Fab7c4 pushed a commit to Fab7c4/paparazzi that referenced this pull request Apr 11, 2015
Paparazzi 5.4.0_stable
======================

Stable version release.

- messages: MOVE_WP and WP_MOVED_LLA with altitude in mm
- ins: immediately effective ins_reset_local_origin
- server: don't fail if settings_modules is missing
- python: messagesapp: growable value column width
- python: add python real time plotter to control panel
- module: mavlink, parse PARAM_SET, send origin and waypoints
- module: FLAPS, HATCH, BRAKE via RC in AUTO1
[paparazzi#878] (paparazzi#878)
- fixedwing: use min/max_cruise_throttle variables instead of defines
[paparazzi#1057] (paparazzi#1057)
- GCS: turn off search in flight plan panel to fix hotkeys
[paparazzi#995] (paparazzi#995)
[paparazzi#1061] (paparazzi#1061)
- GCS: fixes for flight plan editor and keeping map center on zoom
[paparazzi#927] (paparazzi#927)
[paparazzi#1059] (paparazzi#1059)
- stm32/luftboot: update libopencm3 to get usb control call back fix
[paparazzi#1058] (paparazzi#1058)

# gpg: Signature made Mo 05 Jan 2015 17:00:28 CET using RSA key ID
4CEDA267
# gpg: Can't check signature: public key not found

Conflicts:
	.gitmodules
	CHANGELOG.md
	conf/Makefile.arm-embedded-toolchain
	conf/Makefile.linux
	conf/Makefile.lpc21
	conf/Makefile.stm32
	conf/airframes/ardrone2_sdk.xml
	conf/airframes/cridea/quad-suave.xml
	conf/airframes/examples/quadrotor_lisa_m_2_pwm_spektrum.xml
	conf/airframes/examples/quadrotor_mlkf.xml
	conf/firmwares/rotorcraft.makefile
	conf/firmwares/rotorcraft.xml
	conf/firmwares/subsystems/shared/imu_aspirin_v2.1.makefile
	conf/firmwares/subsystems/shared/imu_aspirin_v2.1_old.makefile
	conf/firmwares/subsystems/shared/imu_aspirin_v2.2.makefile
	conf/firmwares/subsystems/shared/imu_aspirin_v2_common.makefile
	conf/firmwares/subsystems/shared/imu_px4fmu_v1.7.makefile
	conf/joystick/ms_sidewinder.xml
	conf/messages.xml
	conf/settings/control/stabilization_att_float_quat.xml
	conf/tests_conf.xml
	data/maps/Makefile
	paparazzi_version
	sw/airborne/arch/lpc21/mcu_periph/spi_slave_hs_arch.c
	sw/airborne/arch/stm32/mcu_periph/i2c_arch.c
	sw/airborne/arch/stm32/subsystems/actuators/actuators_pwm_arch.c
	sw/airborne/arch/stm32/subsystems/radio_control/ppm_arch.c
	sw/airborne/boards/ardrone/at_com.h
	sw/airborne/boards/krooz_sd.h
	sw/airborne/firmwares/fixedwing/main_ap.c
	sw/airborne/firmwares/fixedwing/main_fbw.c
	sw/airborne/firmwares/fixedwing/nav.h
	sw/airborne/firmwares/rotorcraft/autopilot.c
	sw/airborne/firmwares/rotorcraft/main.c
	sw/airborne/firmwares/rotorcraft/navigation.h
	sw/airborne/firmwares/rotorcraft/telemetry.h
	sw/airborne/math/pprz_geodetic_int.c
	sw/airborne/math/pprz_geodetic_int.h
	sw/airborne/mcu.c
	sw/airborne/mcu_periph/i2c.c
	sw/airborne/modules/benchmark/flight_benchmark.c
	sw/airborne/modules/cam_control/cam.c
	sw/airborne/modules/ins/imu_chimu.c
	sw/airborne/modules/multi/formation.c
	sw/airborne/modules/multi/potential.c
	sw/airborne/modules/multi/tcas.c
	sw/airborne/modules/sensors/airspeed_ets.c
	sw/airborne/modules/sensors/baro_MS5534A.h
	sw/airborne/modules/sensors/baro_amsys.h
	sw/airborne/modules/sensors/baro_bmp.h
	sw/airborne/modules/sensors/baro_board_module.h
	sw/airborne/modules/sensors/baro_ets.h
	sw/airborne/modules/sensors/baro_ms5611_i2c.h
	sw/airborne/modules/sensors/baro_scp.h
	sw/airborne/peripherals/mpu60x0_i2c.c
	sw/airborne/state.c
	sw/airborne/state.h
	sw/airborne/subsystems/ahrs/ahrs_float_mlkf.c
	sw/airborne/subsystems/datalink/README.md
	sw/airborne/subsystems/datalink/pprzlog_transport.c
	sw/airborne/subsystems/datalink/superbitrf.c
	sw/airborne/subsystems/datalink/superbitrf.h
	sw/airborne/subsystems/datalink/telemetry.c
	sw/airborne/subsystems/datalink/telemetry_common.h
	sw/airborne/subsystems/gps/gps_ardrone2.c
	sw/airborne/subsystems/imu.h
	sw/airborne/subsystems/imu/imu_aspirin_2_spi.c
	sw/airborne/subsystems/imu/imu_drotek_10dof_v2.c
	sw/airborne/subsystems/imu/imu_um6.c
	sw/airborne/subsystems/ins/ins_alt_float.c
	sw/airborne/subsystems/navigation/OSAMNav.c
	sw/airborne/subsystems/navigation/bomb.c
	sw/airborne/subsystems/navigation/poly_survey_adv.c
	sw/airborne/subsystems/navigation/spiral.c
	sw/airborne/test/test_geodetic.c
	sw/ground_segment/tmtc/Makefile
	sw/in_progress/ir_calibration/Makefile
	sw/in_progress/motor_bench/Makefile
	sw/in_progress/satcom/Makefile
	sw/in_progress/wind_tunnel/Makefile
	sw/lib/ocaml/latlong.ml
	sw/logalizer/Makefile
	sw/simulator/nps/nps_ivy_common.c
	sw/supervision/pc_common.ml
	sw/tools/dfu/stm32_mem.py
	tests/examples/01_compile_all_test_targets.t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants