[lib/ocaml] use ocaml Http_client from netclient lib to download files #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* used e.g. to dowload tiles * raises Blocked if we get a 403 and raises Not_Found on a 404, only if we get a Not_Found we try the next zoom level * in case we get blocked, it still tries the next tile... maybe we should stop trying to get tiles at all in that case
|
Worked for me on OS X (Lion, binary install from august). Couldn't test 403, didn't test 404. |
flixr
added a commit
that referenced
this pull request
Sep 14, 2012
[lib/ocaml] use ocaml Http_client from netclient lib to download files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only if we get a Not_Found we try the next zoom level
maybe we should stop trying to get tiles at all in that case
should at least partially fix #42