Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi] fixed spi initialization stm32f1 #1371

Closed
wants to merge 2 commits into from

Conversation

bartslinger
Copy link
Contributor

Using spi2 on Lisa/S worked if UART3 was also active, but this was a workaround. This is no longer required with this fix.

@kirkscheper
Copy link
Member

Doesn't seem to work with the BlueGiga

@flixr flixr closed this in b11577c Oct 2, 2015
@flixr
Copy link
Member

flixr commented Oct 2, 2015

Uh, sorry @kirkscheper, saw your comment too late...
But the changes to the spi_arch are definitely correct.

flixr added a commit that referenced this pull request Oct 2, 2015
@flixr
Copy link
Member

flixr commented Oct 2, 2015

@kirkscheper should be fixed for slave mode as well now

@kirkscheper
Copy link
Member

Will test and let you know.
On 2 Oct 2015 3:23 pm, "Felix Ruess" [email protected] wrote:

@kirkscheper https://github.com/kirkscheper should be fixed for slave
mode as well now


Reply to this email directly or view it on GitHub
#1371 (comment).

@kirkscheper
Copy link
Member

Nope, still doesn't work

@kirkscheper
Copy link
Member

typo: sw/airborne/arch/stm32/mcu_periph/spi_arch.c:1338

was
gpio_setup_pin_af(GPIO_BANK_SPI2_MISO, GPIO_SPI1_MISO, 0, TRUE);

should be
gpio_setup_pin_af(GPIO_BANK_SPI2_MISO, GPIO_SPI2_MISO, 0, TRUE);

@kirkscheper
Copy link
Member

with this fix it works

@flixr
Copy link
Member

flixr commented Oct 2, 2015

thx, typo fixed

@bartslinger bartslinger deleted the lisas_spi_init_fix branch October 3, 2015 21:26
@flixr flixr added the STM32 label Nov 22, 2015
@flixr flixr added this to the v5.8 milestone Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants