Skip to content

Rebasing onto QEMU master workflows #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 120 commits into
base: main
Choose a base branch
from

Conversation

connorc0405
Copy link

@connorc0405 connorc0405 commented Apr 1, 2025

In case you want to manually test these, I changed the ref-changing workflow to point main_test to master instead of main to master. Can change back after review.

@connorc0405 connorc0405 self-assigned this Apr 1, 2025
@lacraig2 lacraig2 force-pushed the main branch 2 times, most recently from 973dd8a to 8b2d81e Compare April 2, 2025 14:32
@connorc0405 connorc0405 requested review from lacraig2 and SykSyn April 4, 2025 14:56
@SykSyn
Copy link
Collaborator

SykSyn commented Apr 8, 2025

My only complaint with this PR right now is that it includes a large number of commits totally unrelated to it (presumably due to force pushing). Any chance you can adjust the source branch to strip out all lacraig2's updates so the updated files are clearer?

I think it seems to be from 4e50044 to c34aacf

pm215 and others added 24 commits April 8, 2025 14:24
On my machine the arm_replay test takes over 2 minutes to run
in a config with Rust enabled and debug enabled:

$ time (cd build/rust ; PYTHONPATH=../../python:../../tests/functional
QEMU_TEST_QEMU_BINARY=./qemu-system-arm ./pyvenv/bin/python3
../../tests/functional/test_arm_replay.py)
TAP version 13
ok 1 test_arm_replay.ArmReplay.test_cubieboard
ok 2 test_arm_replay.ArmReplay.test_vexpressa9
ok 3 test_arm_replay.ArmReplay.test_virt
1..3

real    2m16.564s
user    2m13.461s
sys     0m3.523s

Bump up the timeout to 4 minutes.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20250310102830.3752440-1-peter.maydell@linaro.org
panda_plugin_interface: add prototypes
panda(src): add panda_api

fixup common

callbacks: switch target_ptr_t to uint64_t

callbacks: merge and drop printf

callbacks: temporarily remove libpanda_load
panda_qemu_plugin_helpers: squash me meson
@connorc0405 connorc0405 force-pushed the action-rebase-onto-qemu-master branch from 0aa7450 to 4c2bcf8 Compare April 10, 2025 15:20
@lacraig2 lacraig2 force-pushed the main branch 3 times, most recently from 9ed05e4 to ff8c829 Compare April 25, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants