Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luarocks dependencies moved to .rockspec file #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Luarocks dependencies moved to .rockspec file #316

wants to merge 1 commit into from

Conversation

kariedo
Copy link

@kariedo kariedo commented Feb 13, 2019

Trying to create consistent setup in the CentOS 6 environment and found that if I install the lua-resty-waf with the provided .rockspec - packages that it depends on get installed, but not added to the "luarocks list":

Here the output after the installation:

# luarocks  list
Installed rocks:
----------------
lua-resty-auto-ssl
   0.12.0-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua-resty-http
   0.13-0 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua-resty-waf
   0.11.1-2 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

luarocks-fetch-gitrec
   0.2-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

But of I install dependencies first with luarocks install busted - everything looks good.

Decided to try to move the luarocks dependencies installation from Makefile back to .rockspec and everything looks smoother now and shows consistent list of libraries:

# luarocks list

Installed rocks:
----------------

busted
   2.0.rc13-0 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

dkjson
   2.5-2 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lrexlib-pcre
   2.9.0-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua-resty-auto-ssl
   0.12.0-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua-resty-http
   0.13-0 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua-resty-waf
   0.11.1-2 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua-term
   0.7-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

lua_cliargs
   3.0-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

luafilesystem
   1.7.0-2 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

luarocks-fetch-gitrec
   0.2-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

luassert
   1.7.11-0 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

luasystem
   0.2.1-0 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

mediator_lua
   1.1.2-0 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

penlight
   1.5.4-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

say
   1.3-1 (installed) - /usr/local/openresty/luajit/lib/luarocks/rocks

Are there reasons why this can't be back-ported to your master tree?

And package doesn't build on CentOS 6 system because of the outdated GCC (4.4.7) - had to remove the -flto flag (kariedo/lua-resty-htmlentities@4dbb9bf), but that's different story.

@p0pr0ck5
Copy link
Owner

p0pr0ck5 commented Mar 6, 2019

Thanks! Definitely seems saner to move away from the current pattern (don't know what I was thinking :) ). Would you mind updating the .travis.yml on your branch as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kariedo @p0pr0ck5