Add python 3.4 support #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +13,22 @@ | |||
| import json | |||
|
|
|||
|
|
|||
| if sys.version < '3': | |||
There was a problem hiding this comment.
Isn't it better to use sys.version_info < (3,)? (Not that Python 10 is on the horizon)
|
The classifiers in setup.py should be updated to list the supported Python 3 versions: 'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4' |
|
Thank you salty horse, i've added your suggestions and push with --force flag to update this pull request |
|
Is this pull request stable? When is it planning to merge? Thanks. |
|
This pull request is stable, however it doesn't solve #78 which i plan to solve later |
|
@ozgur any news on this? Can you please consider this pull request? This could pave the way to other pull requests to support the newer API versions. |
|
💯 |
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support both python 2.7 and python 3.4
Fix #77