Removing the email from the scope for Facebook#266
Merged
overtrue merged 1 commit intoovertrue:4.xfrom Sep 1, 2023
woei66:4.x
Merged
Removing the email from the scope for Facebook#266overtrue merged 1 commit intoovertrue:4.xfrom woei66:4.x
overtrue merged 1 commit intoovertrue:4.xfrom
woei66:4.x
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The email permission is not provided by default in Facebook apps.
Therefore, we should not assign "email" in the scope.
If we assing "email" field in the scope, the email will be added to the authorize url and it will fail if devlopers don't request email permission for their Facebook apps.
I provided the return url when I try the Facebook login.
https://www.facebook.com/v3.3/dialog/oauth?client_id=xxxxxx&redirect_uri=https%3A%2F%2Fxxx.xxx%2Fcallback.php&scope=email&response_type=code
You can see that there is a extra parameter "scope=email" is added in the url and it will cause the failure for Facebook login.