Improved pull request "Files Changed" experience feedback #163932
Replies: 2517 comments 952 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
Rendering of commit message looks to be borked currently on Mobile; https://github.com/distribution/distribution/pull/4756/files/adf9d667be9827bea50053fa2e449ccf7f2fcbd9..236505c13d8b0025abab202982f5cc6a8c2a12e7 |
Beta Was this translation helpful? Give feedback.
-
|
Really appreciate the transparency and steady improvements here—file-level commenting and persistent drafts already make large PR reviews much smoother. The opt-in single file mode sounds like the right balance for performance and flexibility. Changes like this are exactly the kind of dev-focused UX refinements we also keep an eye on at https://kattu.com.pk/. |
Beta Was this translation helpful? Give feedback.
-
|
Missing line breaks in annotations forced me to roll back. It's messing up all output from my CI checks. |
Beta Was this translation helpful? Give feedback.
-
|
It used to be that the general contents of a pending review (not individual comments within it) were retained when closing the pop-up. This is no longer the case, and feels like a regression. After I wrote quite some text, I added some more comments, only to find the text had then disappeared. Very poor UX. |
Beta Was this translation helpful? Give feedback.
-
|
On narrow screens it's painful to hide I understand that someone might think these are related actions (filtering files and hiding viewed files), but they really aren't. I'm applying a general preference relating to viewing files (the viewing option is on the right), and instead, I have to go all the way to the left, expand a thing, then go almost all the way to the right to expand another thing (more than I'd normally have to travel if it wasn't collapsed), and then travel some more just to uncheck an option. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
We've encountered unexpected behavior with review comment redirections that's causing confusion during PR reviews. Issue: When clicking the file path at the top of a review comment, it redirects to the file as it appeared in the commit where the comment was originally made, rather than showing the latest version with all subsequent commits. This means changes made after the review comment are not visible. Impact: This caused a misunderstanding during our review process. A reviewer stated that their suggestions hadn't been applied, when in fact they had been implemented in later commits—they just weren't visible due to this redirect behavior. Questions:
Note: We've tried disabling the new diff experience, but the behavior persists—new commits remain filtered out. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
The "new experience" is not showing the codeowners file validation banner: |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Today I had to switch back because I couldn't load files owned by my team on a large PR: https://github.com/github/github/pull/412996/changes?owned-by%5B%5D=guperrot It loaded fast in classic. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
The side-by-side diff view listens to cmd+a (which is fine), but the way it's implemented it also captures cmd+shift+a, which would otherwise open the chrome bar that lets me search open/recently closed tabs. The diff view should not capture that shortcut! |
Beta Was this translation helpful? Give feedback.
-
|
I'm not sure about the actual view yet, but this version seems to not lock up Chrome whereas the old version often does (to the point one has to switch Browsers as a workaround). Actually I notice as I'm typing this in Chrome that the text input is extremely laggy, but it's not freezing completely. |
Beta Was this translation helpful? Give feedback.
-
|
Comment filters for outdated or resolved do NOT work |
Beta Was this translation helpful? Give feedback.
































Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
We're actively working to improve performance. As part of this, the single file mode, which was a temporary solution while we addressed scale and performance issues, will transition to an "opt-in" feature rather than one that is forced on because of the size of the pull request. We're also working to increase the limits on comments, etc.
We know appreciate your patience! ❤️
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
Tip
To opt into the public preview, click the ✨Try the new experience in the upper-right of the "Files changed" page. You can easily switch back by clicking Switch back.
✨ What's new
See what's been fixed and improved since the launch of the public preview:
User experience
Accessibility
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions