OHRM5X-2222: Fix claim - related issues #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DulsaraNethmin
force-pushed
the
OHRM5X-2218
branch
from
c93a2c3 to
ba1eb63
Compare
added 6 commits
May 31, 2023 09:22
DulsaraNethmin
force-pushed
the
OHRM5X-2218
branch
from
ba1eb63 to
e7bb0a8
Compare
ManulMax
suggested changes
May 31, 2023
Comment on lines
381
to
386
| if (!$canNameEdit && $name) { | ||
| throw $this->getInvalidParamException(self::PARAMETER_NAME); | ||
| } | ||
| if ($canNameEdit && $name) { | ||
| $claimEvent->setName($name); | ||
| } |
Author
There was a problem hiding this comment.
used to handle situation like, when sending "name" in a request body for used ClaimEvent.
| * @param ClaimExpense $claimExpense | ||
| */ | ||
| public function setClaimExpense(ClaimExpense $claimExpense): void | ||
| public function setClaimExpense(ClaimExpense $claimExpense, bool $isEdit = false): void |
src/plugins/orangehrmClaimPlugin/test/fixtures/testcases/ClaimExpenseTypeAPITestCases.yaml
Show resolved
Hide resolved
RajithaKumara
requested changes
May 31, 2023
| $this->throwRecordNotFoundExceptionIfNotExist($claimEvent, ClaimEvent::class); | ||
| $canNameEdit = !$this->getClaimService()->getClaimDao()->isClaimEventUsed($id); | ||
| $name = $this->getRequestParams()->getStringOrNull(RequestParams::PARAM_TYPE_BODY, self::PARAMETER_NAME); | ||
| if (!$canNameEdit && $name) { |
Member
There was a problem hiding this comment.
This expression is not clear. Are you going to check this 🤔
if (!$canNameEdit && $name !== '') {
Author
There was a problem hiding this comment.
checking is it null or not.
RajithaKumara
approved these changes
Jun 1, 2023
RajithaKumara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.