Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #312: Fixed intrinsicContentSize size calculation #313

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Issue #312: Fixed intrinsicContentSize size calculation #313

merged 1 commit into from
Jul 20, 2020

Conversation

lancheg
Copy link
Contributor

@lancheg lancheg commented Mar 22, 2019

Fixes #312 issue

@maziyarpanahi maziyarpanahi self-requested a review March 28, 2019 09:41
@maziyarpanahi maziyarpanahi self-assigned this Mar 28, 2019
@maziyarpanahi maziyarpanahi added this to the 1.1.0 milestone Mar 28, 2019
@maziyarpanahi maziyarpanahi modified the milestones: 1.1.0, 1.1.5 May 22, 2019
@neodave
Copy link

neodave commented Oct 9, 2019

This also fixes a vertical formatting issue we noticed in iOS 13

@omurolgunay
Copy link

omurolgunay commented Jan 20, 2020 •
edited
Loading 

extension ActiveLabel {
    open override var intrinsicContentSize: CGSize {
        return super.intrinsicContentSize
    }
}

This will be good solution till this pr merged

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 18, 2020
@maziyarpanahi maziyarpanahi changed the base branch from master to 115-release-candidate July 20, 2020 00:00
@stale stale bot removed the stale label Jul 20, 2020
@maziyarpanahi maziyarpanahi merged commit 8986a93 into optonaut:115-release-candidate Jul 20, 2020
@maziyarpanahi maziyarpanahi mentioned this pull request Nov 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi Awaiting requested review from maziyarpanahi

Assignees

@maziyarpanahi maziyarpanahi

Labels
None yet
Projects
None yet
Milestone
1.1.5
Development

Successfully merging this pull request may close these issues.

Invalid intrinsicContentSize with bold style of active elements
4 participants
@lancheg @neodave @omurolgunay @maziyarpanahi