Unbound - allow TTL on host overrides. Fixes: #7597 #7616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdSchellevis
force-pushed
the
master
branch
5 times, most recently
from
6586a65 to
607e32a
Compare
AdSchellevis
force-pushed
the
master
branch
2 times, most recently
from
bfdf0d3 to
968e5f9
Compare
|
@bensmithurst it looks like I forgot about this PR, since quite some code has changed, we now only need 84f4898 to add ttl's here. |
fichtner
pushed a commit
that referenced
this pull request
Apr 2, 2025
(cherry picked from commit 84f4898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #7597
This seems to work for me, but as my first OPNsense PR I can believe there are various best practice points I have missed. Hopefully it is a useful starting point for me or someone else to refine further.