Instead of relying on existing service/role directories create them on s... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n startup It makes the service start a lot easier when the hub daemon takes care about creating the service/role directories on its own instead of doing this job as part of the init script (which is very close to the daemon anyway). Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
ghost
assigned 
|
This looks like a reasonable change, and doesn't add any specific directory names into the code since it just checks to see if conf-specified directories exist and if not it creates them. |
|
Yes, and it makes it pretty easy to start ls-hubd for example with systemd without caring about required directory structures (see https://github.com/webOS-ports/webos-systemd-services/blob/master/ls-hubd_private.service for example). |
ohhmm
suggested changes
May 16, 2021
| if (!g_file_test(path, G_FILE_TEST_IS_DIR)) | ||
| { | ||
| g_warning("WARNING: service directory \"%s\" does not exist. Attempting to create it ...", path); | ||
| g_mkdir(path, 0777); |
|
Hi @kdopen, I guess we missed this back then. Have a nice day, |
|
surprise on getting a comment on a commit from 8 years ago. Are you working with webOS now? i'm pretty sure that all of the current activity is over in the repos that LG made, or in LuneOS. |
|
Just was grooming through my old work:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...tartup
It makes the service start a lot easier when the hub daemon takes care about creating the
service/role directories on its own instead of doing this job as part of the init script
(which is very close to the daemon anyway).
Open-webOS-DCO-1.0-Signed-off-by: Simon Busch [email protected]