Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snippets] [ARM]:Enable Comparison ops tokenization in CPU Plugin #28231

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

xyz-harshal
Copy link
Contributor

Details:

  • Enabled Snippets Tokenization of comparison operations (Equal,Greater,GreaterEqual,LessEqual) on AArch64 devices.
  • Registerd the operations with the corresponding JIT emitters in CPUTargetMachine

Tickets:

image

@xyz-harshal xyz-harshal requested review from a team as code owners December 30, 2024 13:31
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Dec 30, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Dec 30, 2024
@xyz-harshal
Copy link
Contributor Author

Hi @a-sidorova could you review the PR!
Thanks!

@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova a-sidorova self-assigned this Dec 30, 2024
@a-sidorova a-sidorova added this to the 2025.0 milestone Dec 30, 2024
@a-sidorova a-sidorova added the platform: arm OpenVINO on ARM / ARM64 label Dec 30, 2024
Copy link
Contributor

@a-sidorova a-sidorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyz-harshal thank you for the contribution!

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Jan 2, 2025
@a-sidorova a-sidorova removed this pull request from the merge queue due to a manual request Jan 2, 2025
@a-sidorova
Copy link
Contributor

@xyz-harshal could you please remove the last commit which includes Negative-related changes? Please create new PR with the Negative implementation.

This PR should contain only Snippets-related changes and it was ready to be merged.

@a-sidorova
Copy link
Contributor

build_jenkins

@xyz-harshal
Copy link
Contributor Author

i am sorry @a-sidorova @dmitry-gorokhov
now everything looks good

@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova a-sidorova added this pull request to the merge queue Jan 2, 2025
Merged via the queue into openvinotoolkit:master with commit 638f3cb Jan 2, 2025
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [Snippets] [ARM]: Enable Comparison ops tokenization in CPU Plugin
4 participants