Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippets] [ARM]: Fixed bug in PReLU emitter, enabled PReLU, Sqrt, Round tokenization #28223

Merged
merged 8 commits into from
Jan 6, 2025
Merged

[Snippets] [ARM]: Fixed bug in PReLU emitter, enabled PReLU, Sqrt, Round tokenization #28223

merged 8 commits into from
Jan 6, 2025
+80 −26

Conversation

0xfedcafe
Copy link
Contributor

Details:

  • Fixed a bug in PReLU emitter
  • Enabled PReLU, Sqrt, Round tokenization
  • All local tests pass

Tickets:

@0xfedcafe 0xfedcafe requested review from a team as code owners December 29, 2024 02:33
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Dec 29, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Dec 29, 2024
@dmitry-gorokhov
Copy link
Contributor

build_jenkins

@dmitry-gorokhov dmitry-gorokhov added this to the 2025.0 milestone Dec 29, 2024
@a-sidorova a-sidorova linked an issue Dec 30, 2024 that may be closed by this pull request
[Good First Issue] [Snippets] [ARM]: Enable PRelu, Sqrt, Round tokenization in CPU Plugin #28161
Closed
@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova
Copy link
Contributor

@0xfedcafe many tests for Round op are failed in CI job ie_tests_cpu_debian_10_arm_release with the following error:

Value of: primTypeCheck(primType)
  Actual: false
Expected: true
primType is unexpected : ref_f32 Expected : acl_f32

This job is on aarch32. On aarch32 we doesn't support JIT emitters. Also looks like ACL doesn't contain kernel for Round op on aarch32.
Could you please add round-related types to here and here? With these changes, on aarch64 we will expect primitive type jit_f32 and on aarch32 - ref_f32.

@a-sidorova
Copy link
Contributor

a-sidorova commented Jan 3, 2025 •
edited
Loading

@0xfedcafe recently we merged the same PR with tokenization support of other operations. Because of that now we have merge conflicts. Could you please rebase on the latest master and fix them? I will relaunch CI. Sorry for that!

@a-sidorova
Copy link
Contributor

build_jenkins

a-sidorova
a-sidorova approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@a-sidorova a-sidorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xfedcafe thanks a lot for the contribution! Good job! 👍🏼

@a-sidorova a-sidorova added the platform: arm OpenVINO on ARM / ARM64 label Jan 6, 2025
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Jan 6, 2025
Merged via the queue into openvinotoolkit:master with commit 1d955cd Jan 6, 2025
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-sidorova a-sidorova a-sidorova approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [Snippets] [ARM]: Enable PRelu, Sqrt, Round tokenization in CPU Plugin
4 participants
@0xfedcafe @dmitry-gorokhov @a-sidorova @sys-openvino-ci