Skip to content

Conversation

@redradist
Copy link

No description provided.

@redradist
Copy link
Author

@dmitry-gorokhov Could someone to approve CI for this PR ?

@dmitry-gorokhov
Copy link

Hi @redradist. Could you please clarify why we need this patch in OpenVINO oneDNN fork? It is used as a backend for OV CPU Plugin and not supposed to be built targeting NVIDIA GPUs.

@redradist
Copy link
Author

redradist commented Dec 12, 2024

Hi @redradist. Could you please clarify why we need this patch in OpenVINO oneDNN fork? It is used as a backend for OV CPU Plugin and not supposed to be built targeting NVIDIA GPUs.

@dmitry-gorokhov This patch is needed to be able to compile nvidia_plugin on system with OpenCL 3.0.
Standard mechanism is not working for detecting OpenCL 3.0 version

@dmitry-gorokhov
Copy link

@redradist Does OV nvidia_plugin uses smt from this oneDNN fork?
Since this fork is used for CPU only, we are disabling GPU build by default (https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/thirdparty/CMakeLists.txt#L45). In other words cmake/FindOpenCL.cmake shoudn't be called at all.

@redradist
Copy link
Author

redradist commented Dec 13, 2024

@redradist Does OV nvidia_plugin uses smt from this oneDNN fork? Since this fork is used for CPU only, we are disabling GPU build by default (https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/thirdparty/CMakeLists.txt#L45). In other words cmake/FindOpenCL.cmake shoudn't be called at all.

It is used in OpenVINO for CPU and GPU plugins, in both places I had to modify this cmake to be able to comiple OpenVINO as dependecy and then NVIDIA Plugin

@redradist
Copy link
Author

@redradist Does OV nvidia_plugin uses smt from this oneDNN fork? Since this fork is used for CPU only, we are disabling GPU build by default (https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/thirdparty/CMakeLists.txt#L45). In other words cmake/FindOpenCL.cmake shoudn't be called at all.

Also, one additional comment, reviously this cmake/FindOpenCL.cmake worked properly, but since NVIDIA update they driver with support of OpenCL 3.0, it is broken (I've mentioned it here as well uxlfoundation#2001 (comment))

@dmitry-gorokhov
Copy link

dmitry-gorokhov commented Dec 16, 2024

@redradist My point is OV CPU plugin set DNNL_GPU_RUNTIME to NONE, so cmake/FindOpenCL.cmake is just not installed in that case. Maybe I miss smt, but couldn't really understand how this fork affected GPU build. Maybe you can share details.
OV GPU Plugin uses stock oneDNN library (w/o any forks), so indeed the PR uxlfoundation#2001 is required.

@redradist
Copy link
Author

@redradist My point is OV CPU plugin set DNNL_GPU_RUNTIME to NONE, so cmake/FindOpenCL.cmake is just not installed in that case. Maybe I miss smt, but couldn't really understand how this fork affected GPU build. Maybe you can share details. OV GPU Plugin uses stock oneDNN library (w/o any forks), so indeed the PR oneapi-src#2001 is required.

@dmitry-gorokhov Because GPU plugin could be used for NVIDIA GPU, that is why I did not disable it.
Anyway it should work without disabling of GPU plugin, because OpenCL headers are provided

@dmitry-gorokhov
Copy link

GPU Plugin doesn't use this oneDNN fork: https://github.com/openvinotoolkit/oneDNN.
They use stock oneDNN. See: https://github.com/openvinotoolkit/openvino/blob/master/.gitmodules#L52-L54

@redradist
Copy link
Author

redradist commented Feb 27, 2025

GPU Plugin doesn't use this oneDNN fork: https://github.com/openvinotoolkit/oneDNN. They use stock oneDNN. See: https://github.com/openvinotoolkit/openvino/blob/master/.gitmodules#L52-L54

Hmm, maybe something changed in latest version of openvino ...
Okay, what is for used this oneDNN fork then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants