Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Support References in Variable Validation #2216

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WIP: Support References in Variable Validation #2216

wants to merge 5 commits into from
+86 −44

Conversation

cam72cam
Copy link
Member

Open questions:

  • How do we handle when values are unknown during the plan phase?

Resolves #1336

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@cam72cam
Initial work to support variable validation references
1bf6a52 
This wires in the basic functionallity.  Additional testing and
validation is needed.

Signed-off-by: Christian Mesh <[email protected]>
@github-actions GitHub Actions
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@apparentlymart apparentlymart mentioned this pull request Nov 26, 2024
Open
@apparentlymart
Copy link
Contributor

There's a report about an unrelated bug in this area over in #2219, which I marked as blocked just to avoid a solution to that conflicting with the work in this PR.

It might be worth incorporating a fix for that bug into this PR since you presumably already have the relevant context loaded in your brain to implement and test it, but if you decide against that please remove the "blocked" label from that issue once this PR is closed so we can know it's read to work on.

Base automatically changed from 2175_split_variable_contexts to main December 2, 2024 14:18
@cam72cam cam72cam force-pushed the 1336_variable_validation_references branch from 56b6f08 to 0d672b5 Compare December 2, 2024 16:06
@apparentlymart apparentlymart mentioned this pull request Dec 2, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cam72cam @apparentlymart