Split variable evaluation / validation scope #2199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
Currently, GraphNodeReferenceOutside is used to make sure that variables are evaluated in the correct scope. However, with the addition of function providers and "bugfixes" introduced in provider iteration, variables now require two completely distinct scopes. One scope is used for variable evaluation from module call inputs, the other for the validation scope. These two scopes are now represented by the original struct in charge of the variable, and an new one which only contains the validation logic. Only the new "validation scope" node provides the reference and will be depended on, other nodes may use the value post-validation. Additionally ProviderFunctionTransformer now understands GraphNodeReferenceOutside, which fixes a few related bugs. Idealy, we could get rid of that interface, but due to how expansion is handled, it's quite tricky. This also implements a lot of the required machinery for #1336. Signed-off-by: Christian Mesh <[email protected]>
cam72cam
force-pushed
the
2175_split_variable_contexts
branch
from
1ecf689
to
7327626
Compare
abstractionfactory
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GraphNodeReferenceOutside is used to make sure that variables are evaluated in the correct scope. However, with the addition of function providers and "bugfixes" introduced in provider iteration, variables now require two completely distinct scopes.
One scope is used for variable evaluation from module call inputs, the other for the validation scope. These two scopes are now represented by the original struct in charge of the variable, and an new one which only contains the validation logic.
Only the new "validation scope" node provides the reference and will be depended on, other nodes may use the value post-validation.
Additionally ProviderFunctionTransformer now understands GraphNodeReferenceOutside, which fixes a few related bugs. Idealy, we could get rid of that interface, but due to how expansion is handled, it's quite tricky.
This also implements a lot of the required machinery for #1336.
Resolves #2175
Target Release
1.9.0
Checklist
Go checklist
Website/documentation checklist