Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect when provider and resource/module have identical for_each #2186

Merged
merged 12 commits into from
Dec 3, 2024
+628 −36
Merged

Detect when provider and resource/module have identical for_each #2186

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0ba6a46
Detect when provider and resource/module have identical for_each
cam72cam Nov 19, 2024
bfd24a2
Move TraverseStr into addrs
cam72cam Nov 25, 2024
e7fe712
Cleanup provider iteration validation
cam72cam Nov 25, 2024
4cffa61
Better provider validation message
cam72cam Nov 25, 2024
6f484ab
Exclude data blocks from provider iteration check
cam72cam Nov 25, 2024
2055a2c
Forgot to add addrs/traversal.go ...
cam72cam Nov 25, 2024
b0e3c37
rfc: Revision of "Static Evaluation of Provider Iteration"
apparentlymart Nov 26, 2024
fecd093
Include target information in for_each provider warning
cam72cam Dec 2, 2024
595fa93
Update provider for_each validation for RFC changes
cam72cam Dec 2, 2024
203309b
addrs: TraversalsEquivalent function
apparentlymart Dec 3, 2024
99cfa66
configs: use addrs.TraversalsEquivalent to compare traversals
apparentlymart Dec 3, 2024
25645d8
Update provider for_each warning
cam72cam Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
configs: use addrs.TraversalsEquivalent to compare traversals 
We now have a function directly intended for comparing two traversals for
equivalence, so we no longer need to cheat and use comparison of the
string representations that were intended for use only in the UI.

Signed-off-by: Martin Atkins <[email protected]>
  • Loading branch information
@apparentlymart
apparentlymart committed Dec 3, 2024
commit 99cfa66b153aac7ec365d2cc3ee4e2d596bb42d5
4 changes: 2 additions & 2 deletions internal/configs/provider_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,15 +896,15 @@ func providerIterationIdentical(a, b hcl.Expression) bool {
switch as := a.(type) {
case *hclsyntax.ScopeTraversalExpr:
if bs, bok := b.(*hclsyntax.ScopeTraversalExpr); bok {
return addrs.TraversalStr(as.Traversal) == addrs.TraversalStr(bs.Traversal)
return addrs.TraversalsEquivalent(as.Traversal, bs.Traversal)
}
case *hclsyntax.LiteralValueExpr:
if bs, bok := b.(*hclsyntax.LiteralValueExpr); bok {
return as.Val.Equals(bs.Val).True()
}
case *hclsyntax.RelativeTraversalExpr:
if bs, bok := b.(*hclsyntax.RelativeTraversalExpr); bok {
return addrs.TraversalStr(as.Traversal) == addrs.TraversalStr(bs.Traversal) &&
return addrs.TraversalsEquivalent(as.Traversal, bs.Traversal) &&
providerIterationIdentical(as.Source, bs.Source)
}
case *hclsyntax.FunctionCallExpr:
Expand Down
Loading