Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement override resources for mock providers #2168

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

implement override resources for mock providers #2168

wants to merge 9 commits into from

Conversation

ollevche
Copy link
Member

@ollevche ollevche commented Nov 14, 2024 •
edited
Loading

Resolves #2048

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@github-actions GitHub Actions
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@ollevche ollevche force-pushed the add-override-res-to-mock-providers branch 3 times, most recently from a2375b5 to 664c170 Compare November 18, 2024 09:31
@ollevche ollevche marked this pull request as ready for review November 18, 2024 09:54
@ollevche ollevche requested a review from a team as a code owner November 18, 2024 09:54
@cam72cam cam72cam self-assigned this Nov 19, 2024
@ollevche ollevche force-pushed the add-override-res-to-mock-providers branch from 664c170 to 73631a4 Compare November 27, 2024 09:04
cam72cam
cam72cam previously approved these changes Dec 2, 2024
View reviewed changes
@ollevche
implement override resources for mock providers
b19148b 
Signed-off-by: ollevche <[email protected]>
@ollevche
fix: shallow copy of map introduces concurrent writes
ccca751 
Signed-off-by: ollevche <[email protected]>
@ollevche
fix mock values getter
81577d9 
Signed-off-by: ollevche <[email protected]>
@ollevche
fix linting
82f4ff3 
Signed-off-by: ollevche <[email protected]>
@ollevche
reduce download size when running TestMocksAndOverrides
0605333 
Signed-off-by: ollevche <[email protected]>
@ollevche
fix parsing override blocks
488ba27 
Signed-off-by: ollevche <[email protected]>
@ollevche
extend e2e tests for tofu test
408c13a 
Signed-off-by: ollevche <[email protected]>
@ollevche
put missing file permissions so local files are always valid
c61f5ea 
Signed-off-by: ollevche <[email protected]>
@ollevche
add docs and changelog
1e37a48 
Signed-off-by: ollevche <[email protected]>
@ollevche ollevche force-pushed the add-override-res-to-mock-providers branch from 73631a4 to 1e37a48 Compare December 2, 2024 18:01
cam72cam
cam72cam previously approved these changes Dec 2, 2024
View reviewed changes
@ollevche ollevche dismissed cam72cam’s stale review December 2, 2024 18:11

Tests are not in sync with the changes from main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cam72cam cam72cam cam72cam left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cam72cam cam72cam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mock provider level resource overrides
2 participants
@ollevche @cam72cam