Allow client certs to be read by apache #365
Conversation
There was a problem hiding this comment.
Since openshift_origin inherits from params you can write ${::openshift_origin::ruby_scl_path_prefix}. Then it can easily be made into a real parameter without changing all the code.
There was a problem hiding this comment.
I now see this is an existing pattern so it may be better to stay consistent.
There was a problem hiding this comment.
not sure what you mean here, what do you recommend changing?
There was a problem hiding this comment.
I was recommending not using the openshift_origin::params class directly but always through the openshift_origin class but now I'm recommending to stay consistent. So either keep it as it is now or change all references to openshift_origin::params. It would make sense to do that in another patch.
There was a problem hiding this comment.
Agreed, lets stay consistent for now.
I have several blog posts queued up to read regarding params pattern and think we should definitely revisit properly implementing it soon.
|
👍 |
|
[test] |
|
Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3180/) |
|
Evaluated for origin up to ad02880 |
Allow client certs to be read by apache
4 participants
Although oo-mco ping will succeed, application creation will fail because apache cannot read the certs. Moving them to an apache readable location works around this issue.