Skip to content

Added IPsec file #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bfallonf merged 1 commit into from
Dec 15, 2016
Merged

Added IPsec file #3398

bfallonf merged 1 commit into from
Dec 15, 2016

Conversation

@bfallonf
Copy link

@bfallonf bfallonf commented Dec 15, 2016

@bfallonf bfallonf mentioned this pull request Dec 15, 2016
Closed
@bfallonf bfallonf added this to the Next Release milestone Dec 15, 2016
@bfallonf
Copy link
Author

bfallonf commented Dec 15, 2016

[rev_history]
|xref:../admin_guide/ipsec.adoc#admin-guide-ipsec[Encrypting Hosts with IPsec]
|Added the section on encrypting hosts with IPsec.
%

ahardin-rh
ahardin-rh reviewed Dec 15, 2016
View reviewed changes
admin_guide/ipsec.adoc Outdated
Copy link
Contributor

@ahardin-rh ahardin-rh Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the note in a NOTE box?

ahardin-rh
ahardin-rh reviewed Dec 15, 2016
View reviewed changes
admin_guide/ipsec.adoc Outdated
Copy link
Contributor

@ahardin-rh ahardin-rh Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Certificate Authority/certificate authority

ahardin-rh
ahardin-rh reviewed Dec 15, 2016
View reviewed changes
admin_guide/ipsec.adoc Outdated
Copy link
Contributor

@ahardin-rh ahardin-rh Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Certificate Authority/certificate authority

ahardin-rh
ahardin-rh reviewed Dec 15, 2016
View reviewed changes
admin_guide/ipsec.adoc Outdated
Copy link
Contributor

@ahardin-rh ahardin-rh Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/have been/are

@ahardin-rh
Copy link
Contributor

ahardin-rh commented Dec 15, 2016

@bfallonf Just a few comments from me. Other than that, looks good!

@bfallonf
Copy link
Author

bfallonf commented Dec 15, 2016

Thanks @ahardin-rh . Suggestions taken. I'll merge.

@bfallonf bfallonf merged commit 9c13912 into openshift:master Dec 15, 2016
@bfallonf bfallonf deleted the ipsec branch December 16, 2016 01:23
@bfallonf bfallonf modified the milestones: Next Release, Staging, Published - 20/12/2016 Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

Assignees

No one assigned

Labels

branch/enterprise-3.3

Projects

None yet

Milestone

Published - 12/20/16

Development

Successfully merging this pull request may close these issues.

2 participants

@bfallonf @ahardin-rh