Skip to content

Conversation

@php-coder
Copy link

@php-coder php-coder commented Nov 22, 2016

Notes:

  • this also touch atomic-registry documentation (BTW, why it looks so poor and code listings aren't readable?)
  • I didn't modify install_config/upgrading/manual_upgrades.adoc because I'm not sure whether it should be updated

PTAL @mfojtik @openshift/team-documentation

Related to: openshift/origin#11814
Trello card: https://trello.com/c/de9h5mA4/829-3-allow-configuration-of-expiration-date-for-generated-certs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This NOTE doesn't enclosed in ==== because otherwise we'll break the example section.

@php-coder php-coder changed the title oadm ca: document --expire-days option [WIP] oadm ca: document --expire-days option Dec 13, 2016
@php-coder php-coder force-pushed the document_oadm_ca_expire_days_option branch from 2e382eb to 24a5511 Compare December 13, 2016 15:36
@php-coder php-coder changed the title [WIP] oadm ca: document --expire-days option Document --expire-days and --signer-expire-days options Dec 13, 2016
@php-coder
Copy link
Author

PTAL @mfojtik @openshift/team-documentation

@php-coder php-coder force-pushed the document_oadm_ca_expire_days_option branch from 24a5511 to 95a6f4d Compare December 13, 2016 17:38
@vikram-redhat
Copy link
Contributor

@bfallonf - PTAL.

@bfallonf
Copy link

Thanks @php-coder . I'll wait until @mfojtik gives the thumbs up before making following up.

====
The undermentioned commands generate certificate files that will be valid for 2
years (and 5 years for Certification authority (CA) certificate). These
periods can be altered with `--expire-days` and `--signer-expire-days` options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/altered/extended/ ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Extending" means that we can only make the value greater, but this option allows to change the value and user decides whether make it greater or lesser.

@mfojtik
Copy link
Contributor

mfojtik commented Dec 15, 2016

@openshift/team-documentation LGTM

@bfallonf
Copy link

Cool. Thanks @php-coder @mfojtik . I'll merge this and do a followup.

@bfallonf bfallonf merged commit e1c41c5 into openshift:master Dec 16, 2016
@bfallonf bfallonf mentioned this pull request Dec 16, 2016
@php-coder php-coder deleted the document_oadm_ca_expire_days_option branch December 16, 2016 10:52
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.5 GA Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants