optimize the rbac and functions of node-proxy #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: renyunkang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: renyunkang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
approved
Signed-off-by: renyunkang <[email protected]>
renyunkang
force-pushed
the
node-proxy
branch
from
acbf7e6 to
9567777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this ?:
Optimized RBAC permissions for the node-proxy component.
This refers to refining the Role-Based Access Control rules specifically for the node-proxy to ensure it only has the necessary permissions to perform its functions, enhancing security and minimizing potential risks.
Enhanced node-proxy functionality.
Storing allocation results in the
ingress.hostnamefield instead ofingress.ip. Directly usingingress.ipfor storage can lead to kube-proxy's IPVS binding to that IP, potentially impacting the node's network stability. To circumvent this, the allocation results are stored iningress.hostname, which doesn't accept raw IP addresses. To accommodate this, an "lb-" prefix is added to the IP address.We can consider implementing Load Balancer IP Mode for Services in the future.
Related links:
node-proxy: #214
https://github.com/openelb/openelb/security/advisories/GHSA-xg5w-m7qr-r8ch