Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Layer2 Speaker #380

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Refactor Layer2 Speaker #380

merged 4 commits into from
Jan 25, 2024

Conversation

renyunkang
Copy link
Member

Description

What type of PR is this ?:

  • Refactored layer2 speaker and introduced memberlist to solve the single point of failure and implement failover.
  • Fixed some issues with controller IPAM updating service status.

TODO:

  • Standardize log format.
  • More tests for stability.
  • Integrate the decision logic of speaker and controller, as they share the same logic.

Related links:

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 11, 2024
@chaunceyjiang
Copy link
Contributor

/assign

chaunceyjiang
chaunceyjiang reviewed Jan 25, 2024
View reviewed changes
deploy/openelb.yaml
@@ -1122,6 +1122,14 @@ subjects:
namespace: openelb-system
---
apiVersion: v1
data:
key: b3BlbmVsYi1zcGVha2Vycw==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, where did the b3BlbmVsYi1zcGVha2Vycw== of this key come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the base64 encoding of "openelb-speakers". As you can see, I use "openelb-speakers" as the default secret for the memberlist in OpenELB. Of course, you can also customize the secret by modifying the Secret resource.

@renyunkang
refactor(speaker): refactor layer2 speaker
d2c43e9 
Signed-off-by: renyunkang <[email protected]>

fix(ipam): fix ipam update service status error

Signed-off-by: renyunkang <[email protected]>

fix secret

Signed-off-by: renyunkang <[email protected]>

clean up redundant configuration requeue

Signed-off-by: renyunkang <[email protected]>
chaunceyjiang
chaunceyjiang approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. labels Jan 25, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ca8b5745d8030647e1697599eec767630a3fbcd2

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ca8b5745d8030647e1697599eec767630a3fbcd2

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chaunceyjiang,renyunkang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chaunceyjiang,renyunkang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 5314558 into openelb:refactor Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang approved these changes

Assignees

@chaunceyjiang chaunceyjiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renyunkang @chaunceyjiang @ks-ci-bot