Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocate eip to specified namespace #352

Merged
merged 1 commit into from
Aug 29, 2023
Merged

allocate eip to specified namespace #352

merged 1 commit into from
Aug 29, 2023

Conversation

cherryFloris
Copy link
Contributor

Description

What type of PR is this ?:

  1. remove the verification related to the protocol field
  2. update eip resources field
  3. add the feature of binding eip to namespace
  4. Improve the logic of default eip

@ks-ci-bot ks-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 7, 2023
@renyunkang renyunkang self-assigned this Aug 7, 2023
@renyunkang
Copy link
Member

Well done. But I think you didn't modify speaker component.
Can you complete the code modification of the speaker component at the same time? We will review the code after you complete it.

@cherryFloris cherryFloris force-pushed the refactor-ospp branch 2 times, most recently from 5987f95 to e11dd0e Compare August 17, 2023 05:53
renyunkang
renyunkang requested changes Aug 17, 2023
View reviewed changes
config/crd/bases/role.yaml Outdated Show resolved Hide resolved
pkg/controllers/ipam/ipam.go Outdated Show resolved Hide resolved
deploy/openelb.yaml Outdated Show resolved Hide resolved
deploy/openelb.yaml Outdated Show resolved Hide resolved
pkg/controllers/ipam/ipam_test.go Outdated Show resolved Hide resolved
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cherryFloris, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cherryFloris, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@chaunceyjiang
Copy link
Contributor

Thanks~

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c6827ad2c21bc94851474809b14eaa63685f3319

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c6827ad2c21bc94851474809b14eaa63685f3319

@ks-ci-bot ks-ci-bot merged commit 6c21362 into openelb:refactor-ospp Aug 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@renyunkang renyunkang renyunkang approved these changes

Assignees

@chaunceyjiang chaunceyjiang

@renyunkang renyunkang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherryFloris @renyunkang @ks-ci-bot @chaunceyjiang