refactor openelb vip speaker #338
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: renyunkang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: renyunkang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
approved
ks-ci-bot
added
size/L
pkg/speaker/vip/keepalived.go
Outdated
| @@ -288,3 +316,13 @@ func NewKeepAlived(client *clientset.Clientset, conf *KeepAlivedConfig) *KeepAli | |||
| data: map[string]string{}, | |||
| } | |||
| } | |||
|
|
|||
| // remove openelb-vip-configmap, then remove kube-keepalived-vip auto() | |||
There was a problem hiding this comment.
remove openelb-vip-configmap, then remove kube-keepalived-vip auto()
auto() spelling mistake?
other lgtm.
There was a problem hiding this comment.
remove openelb-vip-configmap, then remove kube-keepalived-vip auto()
auto()spelling mistake?other lgtm.
edited
Signed-off-by: renyunkang <[email protected]>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 40a648ed9001870a013f942f0ded9e8889f72a8e
|
1 similar comment
|
LGTM label has been added. Git tree hash: 40a648ed9001870a013f942f0ded9e8889f72a8e
|
Description
What type of PR is this ?:
/refactor