Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: minor changes to codebase #294

Merged
merged 7 commits into from
Jul 15, 2022
Merged

cleanup: minor changes to codebase #294

merged 7 commits into from
Jul 15, 2022

Conversation

amalthundiyil
Copy link
Contributor

@amalthundiyil amalthundiyil commented Jul 13, 2022 •
edited
Loading

Signed-off-by: Amal Thundiyil [email protected]

Description

What type of PR is this ?: /kind cleanup

Minor changes and cleanup. Read the commits for details.

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 13, 2022
@renyunkang
Copy link
Member

If you renamed constants.go, these places in the Makefile should also be changed simultaneously.

@amalthundiyil
pkg: fix typos and names
bcb057a 
Signed-off-by: Amal Thundiyil <[email protected]>
@amalthundiyil
ci: update Makefile target
4b8e1f9 
Signed-off-by: Amal Thundiyil <[email protected]>
@renyunkang
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. labels Jul 14, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5da793231578ed69200daf9970002a7eaf160be9

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5da793231578ed69200daf9970002a7eaf160be9

@chaunceyjiang
Copy link
Contributor

/lgtm

@renyunkang
Copy link
Member

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amal-thundiyil, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amal-thundiyil, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
@ks-ci-bot ks-ci-bot merged commit e47ceae into openelb:master Jul 15, 2022
@amalthundiyil amalthundiyil deleted the refactor branch July 15, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renyunkang renyunkang Awaiting requested review from renyunkang

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

Assignees

@chaunceyjiang chaunceyjiang

@renyunkang renyunkang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amalthundiyil @renyunkang @ks-ci-bot @chaunceyjiang