Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-bgp switch #252

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

chaunceyjiang
Copy link
Contributor

Signed-off-by: chaunceyjiang [email protected]

fix #245

Signed-off-by: chaunceyjiang <[email protected]>
@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2022
@chaunceyjiang
Copy link
Contributor Author

@zheng1 @renyunkang

@chaunceyjiang chaunceyjiang force-pushed the support_non_bgp_switch branch 2 times, most recently from 5a16a0d to 38f3ba9 Compare March 9, 2022 09:11
Copy link
Member

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good and add some comments.

@chaunceyjiang chaunceyjiang force-pushed the support_non_bgp_switch branch from 38f3ba9 to 8e3d305 Compare March 10, 2022 02:35
Signed-off-by: chaunceyjiang <[email protected]>
@chaunceyjiang chaunceyjiang force-pushed the support_non_bgp_switch branch from 8e3d305 to 3c636e6 Compare March 10, 2022 02:44
@renyunkang
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 245afbc9227c90024ee026547c367e5b546e9a61

@zheng1
Copy link
Collaborator

zheng1 commented Mar 10, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang, zheng1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@ks-ci-bot ks-ci-bot merged commit a5c409a into openelb:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support non-bgp switch
5 participants