eip add default attribute #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2022 11:36
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
ks-ci-bot
added
the
size/L
chaunceyjiang
force-pushed
the
fix_232_2
branch
2 times, most recently
from
0d1defb
to
6fcd02b
Compare
Signed-off-by: chaunceyjiang <[email protected]>
chaunceyjiang
force-pushed
the
fix_232_2
branch
from
10093dc
to
c5a141e
Compare
zheng1
reviewed
Jan 12, 2022
lxm
reviewed
Jan 14, 2022
chaunceyjiang
force-pushed
the
fix_232_2
branch
3 times, most recently
from
cf5ef25
to
6f2ef26
Compare
lxm
reviewed
Jan 17, 2022
lxm
reviewed
Jan 19, 2022
Signed-off-by: chaunceyjiang <[email protected]>
chaunceyjiang
force-pushed
the
fix_232_2
branch
from
6f2ef26
to
7fbf1e3
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: b7accc92beed153a86d4223a088f32c51824bd74
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaunceyjiang, zheng1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chaunceyjiang [email protected]
fix #232 #231