Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting and improving the example Backuping script #1840

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

mahyard
Copy link
Contributor

@mahyard mahyard commented Aug 13, 2019

By this PR,

  1. A typo has been fixed. There is no cs_comment_service_development. indeed its name is cs_comments_service_development ( with an extra 's' after 'comment' ).
  2. A MySQL system database - sys - excluded from the list of databases being dumped.
  3. Adding DROP TABLE IF EXISTS... before CREATE TABLE commands is skipped out. as we have a drop database, adding them are pointless.

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert:
  • Subject matter expert:
  • Doc team review (sanity check, copy edit, or dev edit?): @edx/doc
  • Product review:
  • Partner support:
  • PM review:

FYI: Tag anyone else who might be interested in this PR here.
@nedbat

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 13, 2019

Thanks for the pull request, @mahyard! I've created OSPR-3792 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Aug 13, 2019
@nedbat nedbat merged commit 935111f into openedx:master Aug 13, 2019
@openedx-webhooks
Copy link

@mahyard 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@natabene
Copy link

@mahyard Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants