Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SGP doc #1831

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Added SGP doc #1831

merged 1 commit into from
Jun 7, 2019

Conversation

davestgermain
Copy link
Contributor

@davestgermain davestgermain commented Jun 7, 2019

DOC-XXXX

Add a description of your changes with links to any relevant material.

Date Needed (optional)

If the release date of a feature is known or estimated, provide it to give reviewers guidance on turnaround time.

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert:
  • Subject matter expert:
  • Doc team review (sanity check, copy edit, or dev edit?): @edx/doc
  • Product review:
  • Partner support:
  • PM review:

FYI: Tag anyone else who might be interested in this PR here.

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@stroilova
Copy link
Contributor

👍

@davestgermain davestgermain merged commit ab5c25b into master Jun 7, 2019
@davestgermain davestgermain deleted the dcs/sgp branch June 7, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants