add support of empty api_key #1594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rattrayalex
reviewed
Aug 11, 2024
Collaborator
rattrayalex
left a comment
rattrayalex
left a comment
There was a problem hiding this comment.
Thank you for the PR! We are going to fix this in our codegen system, so chances are high we'll close this PR and fix in a separate one, but appreciate the contribution!
pivonroll
reviewed
Nov 24, 2024
| def auth_headers(self) -> dict[str, str]: | ||
| api_key = self.api_key | ||
| return {"Authorization": f"Bearer {api_key}"} | ||
| headers = {} if api_key == "" else {"Authorization": f"Bearer {api_key}"} |
There was a problem hiding this comment.
What is we set api_key to None?
It should also handle situation in which API key is not set through argument of env variable.
pivonroll
reviewed
Nov 24, 2024
| def auth_headers(self) -> dict[str, str]: | ||
| api_key = self.api_key | ||
| return {"Authorization": f"Bearer {api_key}"} | ||
| headers = {} if api_key == "" else {"Authorization": f"Bearer {api_key}"} |
Collaborator
|
Sorry for the delay, this fix has been pushed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Additional context & links