create root span from slim auto-instrumentation #99
Conversation
to allow avoiding all of the spans created by psr-15 auto-instrumentation, have slim auto-instrumentation create its own root span (which is a slightly simplified version of what psr-15 does).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=============================================
- Coverage 68.00% 57.28% -10.73%
+ Complexity 372 278 -94
=============================================
Files 40 33 -7
Lines 1266 1030 -236
=============================================
- Hits 861 590 -271
- Misses 405 440 +35
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Testing against the demo quoteservice gives the following traces: Slim auto-instrumentation: Slim + psr-15 auto-instrumentation: |
@brettmc Is it now possible to disable one or other instrumentation dynamically at runtime (by using API) without manipulating with installed packages? |
No, it's not. This can only be achieved by either installing or not some of the packages. |
I'm wondering if that would not be a useful feature |
I think it's a good idea, I'll create an issue for it. I don't think we can un-register hooks once they exist, but perhaps checking a configuration - something like |
2 participants
To allow avoiding all of the spans created by psr-15 auto-instrumentation, have slim auto-instrumentation create its own root span (which is a slightly simplified version of what psr-15 does). Now, slim auto-instrumentation can be used with or without psr-15, depending on whether you want to create spans for all psr-15 middlewares or not.