fixing phpstan errors #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a recent phpstan feature is to complain about annotations that are not relevant (eg ignoring an error that is not there), so remove the offending annotations
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
============================================
- Coverage 68.00% 66.49% -1.52%
- Complexity 372 393 +21
============================================
Files 40 42 +2
Lines 1266 1337 +71
============================================
+ Hits 861 889 +28
- Misses 405 448 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Jan 10, 2023
pdelewski
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a recent phpstan feature is to complain about annotations that are not relevant (eg ignoring an error that is not there), so remove the offending annotations