relax otel requirements, dont gitsplit tags #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that we have a beta, the versioning has changed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
============================================
- Coverage 71.46% 70.27% -1.19%
Complexity 379 379
============================================
Files 40 40
Lines 1125 1265 +140
============================================
+ Hits 804 889 +85
- Misses 321 376 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
ugh, using beta broke Symfony - I'll see if I can unbreak it |
- Symfony needs some attention to make it compatible with latest otel API/SDK > 0.0.15, so keep it at that version for now. - dont gitsplit tags, we will do it manually for individual contrib modules post-split, since the contrib modules can be at vastly different stabilities - fix up Dockerfile; the use of semi-colons meant that a docker build would happily continue past errors that weren't the last command in a step
brettmc
changed the title
bobstrecansky
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that we have a beta, the versioning has changed so update projects that can work with beta.
Symfony doesn't, and needs some attention to make it work with >= 0.0.15, so for now peg it to that version
improve Dockerfile, as the use of semi-colons between commands in a build step causes some failures to be ignored, which is never what we want.