Amend bundle kernel listener example #59
Conversation
The example only hooked into the TerminateEvent so the constructor only got called late in the request lifecycle (this happened with symfony/symfony 5.3). By explicitly hooking in to the RequestEvent and calling startSpan there, the span covers all other spans created during the request.
wadjei
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
|
|
|
@wadjei - would you like to sign the CLA so we can merge this? |
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
=========================================
Coverage 95.72% 95.72%
Complexity 177 177
=========================================
Files 17 17
Lines 444 444
=========================================
Hits 425 425
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
love to! But still trying to work out how to fix my being not covered |
|
/easycla |
1 similar comment
|
/easycla |
|
@bobstrecansky I've finally managed to get the PR signed |
|
Awesome, thanks for your contribution @wadjei ! |
2 participants
The example only hooked into the TerminateEvent so the constructor only got called
late in the request lifecycle (this happened with symfony/symfony 5.3).
By explicitly hooking in to the RequestEvent and calling startSpan there, the span
covers all other spans created during the request.