Skip to content

Conversation

@tidal
Copy link
Member

@tidal tidal commented Nov 10, 2021

This PR does the following:

  • Reorganizes the directory structure to be PSR4 compatible
  • Organizes contrib types in dedicated directories, so they can be published as separate packages in the future
  • (applies some more granular fixes for phpstan issues in the SdkBundle tests)

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #30 (bd45001) into main (425cac0) will not change coverage.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #30   +/-   ##
=========================================
  Coverage     94.93%   94.93%           
  Complexity      171      171           
=========================================
  Files            15       17    +2     
  Lines           474      474           
=========================================
  Hits            450      450           
  Misses           24       24           
Impacted Files Coverage Δ
src/Aws/Ec2/Detector.php 97.01% <ø> (ø)
src/Aws/Ecs/DataProvider.php 0.00% <0.00%> (ø)
src/Aws/Eks/DataProvider.php 0.00% <0.00%> (ø)
src/Aws/Lambda/Detector.php 100.00% <ø> (ø)
src/Aws/Xray/IdGenerator.php 100.00% <ø> (ø)
src/Aws/Xray/Propagator.php 100.00% <ø> (ø)
...fony/OtelSdkBundle/Factory/GenericFactoryTrait.php 100.00% <ø> (ø)
src/Symfony/OtelSdkBundle/OtelSdkBundle.php 100.00% <ø> (ø)
...rc/Symfony/OtelSdkBundle/Trace/ExporterFactory.php 100.00% <ø> (ø)
src/Symfony/OtelSdkBundle/Util/ConfigHelper.php 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425cac0...bd45001. Read the comment docs.

Copy link
Contributor

@bobstrecansky bobstrecansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you for this reorganization! Much improved.

@bobstrecansky bobstrecansky merged commit 1536b14 into open-telemetry:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants