moving auto instrumentation installer scripts to contrib #121
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
============================================
+ Coverage 52.72% 62.12% +9.39%
+ Complexity 447 408 -39
============================================
Files 48 44 -4
Lines 1686 1431 -255
============================================
Hits 889 889
+ Misses 797 542 -255
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| $opentelemetry_core_packages = array( | ||
| "open-telemetry/sdk", | ||
| "open-telemetry/api", | ||
| "open-telemetry/sdk-contrib", |
There was a problem hiding this comment.
this is a package we've just deprecated. How about just choosing open-telemetry/exporer-otlp? (Optionally, with the grpc transport and zipkin exporter, too?)
There was a problem hiding this comment.
Yes, that good point. So, for now I will add open-telemetry/exporer-zipkin as well.
| $opentelemetry_core_packages = array( | ||
| "open-telemetry/sdk", | ||
| "open-telemetry/api", | ||
| "open-telemetry/exporer-otlp", |
There was a problem hiding this comment.
| "open-telemetry/exporer-otlp", | |
| "open-telemetry/exporter-otlp", |
pdelewski
force-pushed
the
introducing-auto-instrumentation-installer-package
branch
from
97156f7 to
97ec2b3
Compare
3 participants
I'm moving opentelemetry-php-instrumentation/bin to contrib as discussed in open-telemetry/opentelemetry-php-instrumentation#39